Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(common): replace Never with Infallible #3335

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Oct 4, 2023

hyper might be able to use std::convert::Infallible to describe the error which never happens, instead of hyper::common::never::Never.

Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up, thanks!

@seanmonstar seanmonstar merged commit 5a8f4c0 into hyperium:master Oct 4, 2023
19 checks passed
@tottoto tottoto deleted the replace-never-with-infallible branch October 4, 2023 13:44
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 12, 2024
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants